Incorrect colors for 3D draws

[Nico8340]

Describe the bug

With any 3D DirectX drawing function, if we specify our exact color code using tocolor, but do not draw as postgui, we get an unexpected result: The color will be different from the specified color.

Steps to reproduce

1. Test resource - Download
2. Test resource - Run
3. See the difference between the colors

Version

Client: v1.6.0-release-22408 (Windows 11, 64-bit)
Server: v1.6.0-release-22408 (Windows 11, 64-bit)

Additional context

No response

Relevant log output

No response

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[Nico8340]

During later tests, it turned out that this problem only occurs with CLine3D.

[tederis]

Did you try setColorFilter (0, 0, 0, 0, 0, 0, 0, 0)? The function was added to address this problem.

[tederis]

Just as I thought, the problem lay in the color correction. setColorFilter function is enough to fix it. The details: #3321 (comment).

If you don't want to disable color filters, you can use getColorFilter for calculating the inverse coefficients.

[Nico8340]

If you don't want to disable color filters, you can use getColorFilter for calculating the inverse coefficients.

So should we also remove this code from the material line batcher?
@tederis

[tederis]

If you don't want to disable color filters, you can use getColorFilter for calculating the inverse coefficients.

So should we also remove this code from the material line batcher? @tederis

I'm inclined to the opinion that it should indeed be removed from the material line batcher, yes. Just because the division by two isn't obvious at all and don't even fix the bug.

[Nico8340]

I'm inclined to the opinion that it should indeed be removed from the material line batcher, yes. Just because the division by two isn't obvious at all and don't even fix the bug.

Done.