Support IPv6

[Disinterpreter]

Is your feature request related to a problem? Please describe.
The Internet evolution. Possibility to create a server for playing with friends.

Describe the solution you'd like
Support IPv6 (subj)

Describe alternatives you've considered
IPv4 but there aren't allocated addresses anymore.

Additional context
https://www.google.com/intl/en/ipv6/statistics.html

Statistic from above in nutshell:

• on December 2020 average percent is 33 i.e every fourth visiting google from IPv6
• adaptation in Germany is 54% in the US - 46%, in India - 56% i.e every second visit to the google from IPv6

Short movie from google: https://www.youtube.com/watch?v=-Uwjt32NvVA

https://bugs.mtasa.com/view.php?id=5700

[Pirulax]

Maybe it's a stupid question, but would it be possible to support both ipv4 and v6 at the same time? It should be, right?
This is sadly a mostly netcode a netcode upgrade, for which ccw is responsible. AFAIK he isn't too active, so I presume upgrading it will take a long time.

[patrikjuvonen]

Need to also make sure all necessary MTA backend services have IPv6 configured (master server list, etc.)

And with that we can enable support for IPv6 for curl too.

[Disinterpreter]

Maybe it's a stupid question, but would it be possible to support both ipv4 and v6 at the same time? It should be, right?

Sure. Same with the players, if the server supports ipv4 and ipv6, players can connect to both protocols.

But there is a problem, which depend with ASE, because right now masterlist save IP as 4 char symbols
https://github.com/tederis/ase2json/blob/d368bd63c16a9e82a5b7d0a4e5de6ffd8eb6b919/main.cpp#L29-L40

[prnxdev]

I also wanted to write this suggestion because I am working as much as possible with WSL (hate Windows, sorry). It is possible to start MTA server using Linux libriaries but there is one problem: no one knows why but WSL 2 is not porting localhost correctly so everytime I do Windows restart I have to manualy find IP address of MTA server (it's not big problem but it is). The most powerfull solution is to connect using IPv6 (typing mtasa://[::1]:22003 in connect bar should work but it doesn't).

For all of you: start using WSL. MTA server works really perfect (2 or 3 times faster) and it has Git installed by default. Also you have access to things like apt install ... so you can easly install MySQL for example (and you can also connect via IPv6 to this if you need use some client).

[Disinterpreter]

The issue is assigned to ccw, but we have a lot of things which we need to change before IPv6 implementation.

1. Need add some magic here, like inet_pton this function must be detect ipv6
   

   mtasa-blue/Server/mods/deathmatch/logic/CBanManager.cpp

   Lines 519 to 551 in a0410c6

   	bool CBanManager::IsValidIP(const char* szIP)
   	{
   	char strIP[256] = {'\0'};
   	strncpy(strIP, szIP, 255);
   	strIP[255] = '\0';
   	char* szIP1 = strtok(strIP, ".");
   	char* szIP2 = strtok(NULL, ".");
   	char* szIP3 = strtok(NULL, ".");
   	char* szIP4 = strtok(NULL, "\r");
   	if (szIP1 && szIP2 && szIP3 && szIP4)
   	{
   	if (IsValidIPPart(szIP1) && IsValidIPPart(szIP2) && IsValidIPPart(szIP3) && IsValidIPPart(szIP4))
   	return true;
   	}
   	return false;
   	}
   	bool CBanManager::IsValidIPPart(const char* szIP)
   	{
   	if (IsNumericString(szIP))
   	{
   	int iIP = atoi(szIP);
   	if (iIP >= 0 && iIP < 256)
   	return true;
   	}
   	else if (strcmp(szIP, "*") == 0)
   	return true;
   	return false;
   	}

2. addBan must work with subnets, in the first argument (like 127.0.0.0/20) or like a new argument nevermind, but it need to be made (because ISP give to client /64 subnet of ipv6)
   

   mtasa-blue/Server/mods/deathmatch/logic/CBanManager.cpp

   Lines 97 to 107 in a0410c6

   	CBan* CBanManager::AddBan(const SString& strIP, const SString& strBanner, const SString& strReason, time_t tTimeOfUnban)
   	{
   	if (IsValidIP(strIP.c_str()) && !IsSpecificallyBanned(strIP.c_str()))
   	{
   	CBan* pBan = AddBan(strBanner, strReason, tTimeOfUnban);
   	pBan->SetIP(strIP);
   	return pBan;
   	}
   	return NULL;
   	}

3. find more IP functions and check it.
4. make something with ASE (at the moment IP there is 4 ASCII symbols, but for IPv6 we need to store 40 unicode?? symbols)
5. Our HTTP server feel bad when it got IPv6 address. (probably)
   

   mtasa-blue/Server/mods/deathmatch/logic/CHTTPD.cpp

   Line 69 in b01d0d2

   long lIP = inet_addr(szIP);

   
   and more https://github.com/multitheftauto/mtasa-blue/search?l=C%2B%2B&q=inet_addr

[Pirulax]

inet_pton is outdated anyways, and MSVC has been issuing warning for a long time now.

[Disinterpreter]

inet_pton is outdated anyways, and MSVC has been issuing warning for a long time now.

how the part of Berkeley sockets can be outdated? 🤔 But okay, anyway we need to do something with it.

[patrikjuvonen]

inet_pton is outdated anyways, and MSVC has been issuing warning for a long time now.

Other way around, our inet_addr is deprecated and must be replaced by inet_pton.

I'm looking at this issue now, will publish a new branch that works on this issue.

[Pirulax]

Thanks I knew I missed something.
My bad.

[sbx320]

I'd start by figuring out if adding IPv6 is even feasible to our old RakNet variant. I suppose only @ccw808 can answer that. If not, there's not much reason to put time into the other parts of MTA.

(at the moment IP there is 4 ASCII symbols, but for IPv6 we need to store 40 unicode?? symbols)

Not unicode or ascii. That's just raw data. A 32 Bit IPv4 can be stored as 4 bytes. A 128 Bit IPv6 can be stored as 16 bytes. Another complicated part would be to keep old clients functional with a new IPv6-enabled masterlist.

[patrikjuvonen]

We also need EHS swapped or updated (#896)

[ccw808]

How long will it be before IPv4 addresses are unreachable for some players?