-
Notifications
You must be signed in to change notification settings - Fork 2
Replace GraphQL with AQL-based REST API #148
Conversation
db.py contains this line |
I've also noticed this, and the file still uses those types all over. However, none of the functions that use these types seem to be called anywhere. Specifically, the functions (all within
all use these types but are never called. So if all of the behavior of these functions has been replicated somewhere else, I think we can remove them. |
Yeah, one of the things left to do on this branch is to delete all of that dead code, something I'll do in my next pass over db.py. (Also, in general, if you're commenting on a specific line, it's best to put the comment on that line so that we can have individual threads about these issues.) |
These are functions that used to be used by GraphQL resolvers in carrying out various queries.
ac30e5f
to
b4ce5fc
Compare
I'm having issues seeing the graphs in the client. Not sure if that's a bug with the client? The api is returning 200 |
Can you be more specific? Is it the incoming/outgoing links for a specific node, or some other part of the view? |
Found one bug that might be the one you mentioned; that uncovered another bug I'm working on now. |
I think I also found the same bug, which that last commit fixed. |
Ok, I can see the nodes and also the node edges now. Thanks for the bug reports! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great. I left a couple minor comments for you. I'm also having some general errors with viewing graphs in the client (the edge tables are missing and the nodes/edges don't show up in the main view area) that we should fix before we merge this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more little thing 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found another bug: When I go to the graph and then click a node and change the table parameter of the url, the TableNotFound(table)
is giving the error __init__() missing 1 required positional argument: 'table'
The same thing happens for graph. I'm guessing it's an error with how the error is raised/ the init method of the errrors |
Good catches; fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for all this work, Roni.
Thank you both for your support on this long-running, earthquake-causing branch! |
This works with the client application, but needs some serious review, cleanup, and in-place updates.
Some TODOs:
Some of these may just become new issues, in which case they'll be considered done for the purposes of the TODO list above.
@AlmightyYakob and @JackWilb, please take a look.
Moots and therefore closes #8.
Closes #127 (via 6160bc0).
Closes #150 (via b4ce5fc).
Closes #157 (via f1daea8).