Skip to content

sha256: drop minio in favor of crypto/sha256 for go1.21 and above #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions register/miniosha256/multihash_miniosha256.go

This file was deleted.

22 changes: 22 additions & 0 deletions register/miniosha256/post_go1.21.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//go:build go1.21

// This package has no purpose except to perform registration of multihashes.
//
// It is meant to be used as a side-effecting import, e.g.
//
// import (
// _ "github.com/multiformats/go-multihash/register/miniosha256"
// )
//
// This package registers alternative implementations for sha2-256, using
// the github.com/minio/sha256-simd library for go1.20 and bellow. Go 1.21 and
// later fallback to [github.com/multiformats/go-multihash/register/sha256].
//
// Deprecated: please switch to [github.com/multiformats/go-multihash/register/sha256]
// as of go1.21 the go std has a SHANI implementation that is just as fast. See https://go.dev/issue/50543.
// This will be removed shortly after go1.22 is released.
package miniosha256

import (
_ "github.com/multiformats/go-multihash/register/sha256"
)
29 changes: 29 additions & 0 deletions register/miniosha256/pre_go1_21.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//go:build !go1.21

// This package has no purpose except to perform registration of multihashes.
//
// It is meant to be used as a side-effecting import, e.g.
//
// import (
// _ "github.com/multiformats/go-multihash/register/miniosha256"
// )
//
// This package registers alternative implementations for sha2-256, using
// the github.com/minio/sha256-simd library for go1.20 and bellow. Go 1.21 and
// later fallback to [github.com/multiformats/go-multihash/register/sha256].
//
// Note if you are using go1.21 or above this package is deprecated in favor of
// [github.com/multiformats/go-multihash/register/sha256] because as of go1.21
// the go std has a SHANI implementation that is just as fast. See https://go.dev/issue/50543.
// This will be removed shortly after go1.22 is released.
package miniosha256

import (
"github.com/minio/sha256-simd"

multihash "github.com/multiformats/go-multihash/core"
)

func init() {
multihash.Register(multihash.SHA2_256, sha256.New)
}
21 changes: 21 additions & 0 deletions register/sha256/sha256.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// This package has no purpose except to perform registration of multihashes.
//
// It is meant to be used as a side-effecting import, e.g.
//
// import (
// _ "github.com/multiformats/go-multihash/register/sha256"
// )
//
// This package an implementation of sha256 using the go std, this is recomanded
// if you are using go1.21 or above.
package sha256

import (
"crypto/sha256"

multihash "github.com/multiformats/go-multihash/core"
)

func init() {
multihash.Register(multihash.SHA2_256, sha256.New)
}
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "v0.2.1"
"version": "v0.2.2"
}