-
Notifications
You must be signed in to change notification settings - Fork 60
sha256: drop minio in favor of crypto/sha256 for go1.21 and above #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
//go:build go1.21 | ||
|
||
// This package has no purpose except to perform registration of multihashes. | ||
// | ||
// It is meant to be used as a side-effecting import, e.g. | ||
// | ||
// import ( | ||
// _ "github.com/multiformats/go-multihash/register/miniosha256" | ||
// ) | ||
// | ||
// This package registers alternative implementations for sha2-256, using | ||
// the github.com/minio/sha256-simd library for go1.20 and bellow. Go 1.21 and | ||
// later fallback to [github.com/multiformats/go-multihash/register/sha256]. | ||
// | ||
// Deprecated: please switch to [github.com/multiformats/go-multihash/register/sha256] | ||
// as of go1.21 the go std has a SHANI implementation that is just as fast. See https://go.dev/issue/50543. | ||
// This will be removed shortly after go1.22 is released. | ||
package miniosha256 | ||
|
||
import ( | ||
_ "github.com/multiformats/go-multihash/register/sha256" | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
//go:build !go1.21 | ||
|
||
// This package has no purpose except to perform registration of multihashes. | ||
// | ||
// It is meant to be used as a side-effecting import, e.g. | ||
// | ||
// import ( | ||
// _ "github.com/multiformats/go-multihash/register/miniosha256" | ||
// ) | ||
// | ||
// This package registers alternative implementations for sha2-256, using | ||
// the github.com/minio/sha256-simd library for go1.20 and bellow. Go 1.21 and | ||
// later fallback to [github.com/multiformats/go-multihash/register/sha256]. | ||
// | ||
// Note if you are using go1.21 or above this package is deprecated in favor of | ||
// [github.com/multiformats/go-multihash/register/sha256] because as of go1.21 | ||
// the go std has a SHANI implementation that is just as fast. See https://go.dev/issue/50543. | ||
// This will be removed shortly after go1.22 is released. | ||
package miniosha256 | ||
|
||
import ( | ||
"github.com/minio/sha256-simd" | ||
|
||
multihash "github.com/multiformats/go-multihash/core" | ||
) | ||
|
||
func init() { | ||
multihash.Register(multihash.SHA2_256, sha256.New) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// This package has no purpose except to perform registration of multihashes. | ||
// | ||
// It is meant to be used as a side-effecting import, e.g. | ||
// | ||
// import ( | ||
// _ "github.com/multiformats/go-multihash/register/sha256" | ||
// ) | ||
// | ||
// This package an implementation of sha256 using the go std, this is recomanded | ||
// if you are using go1.21 or above. | ||
package sha256 | ||
|
||
import ( | ||
"crypto/sha256" | ||
|
||
multihash "github.com/multiformats/go-multihash/core" | ||
) | ||
|
||
func init() { | ||
multihash.Register(multihash.SHA2_256, sha256.New) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"version": "v0.2.1" | ||
"version": "v0.2.2" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.