fix: prevent deletion of model files shared by multiple configurations #7317
+96
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7171 - When deleting a model configuration, LocalAI was incorrectly removing model files still referenced by other configurations.
Root Cause
Two bugs in
DeleteModelFromSystem:Line 376: Logic error using OR instead of AND for file extension filtering
Line 379: Incorrect filename comparison prevents skipping the config being deleted
Changes
core/gallery/models.goTest Case
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.