feat: respect context and add request cancellation #7187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
Author
|
Seems we can't propagate client disconnection during non-SSE requests due to |
Owner
Author
|
just as a note, echo doesn't have such issues: labstack/echo#1581 |
mudler
force-pushed
the
feat/context_grpc
branch
from
578b94f to
6cc3285
Compare
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
feat/context_grpc
branch
from
6cc3285 to
38125d9
Compare
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
changed the title
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
feat/context_grpc
branch
2 times, most recently
from
53d8f39 to
89e9874
Compare
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
feat/context_grpc
branch
from
89e9874 to
64519a6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| go func() { | ||
| defer func() { | ||
| // Clear read deadline when goroutine exits | ||
| conn.SetReadDeadline(time.Time{}) |
Check warning
Code scanning / gosec
Errors unhandled Warning
| case <-ticker.C: | ||
| // Set a short deadline - if connection is closed, read will fail immediately | ||
| // If connection is open but no data, it will timeout and we check again | ||
| conn.SetReadDeadline(time.Now().Add(50 * time.Millisecond)) |
Check warning
Code scanning / gosec
Errors unhandled Warning
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
feat/context_grpc
branch
from
64519a6 to
4839d57
Compare
Owner
Author
|
found an ugly workaround, but works for our case. Would be nice if fasthttp supports this natively, but I guess for now that's the only way we can tackle this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR binds the token generation to the request context, and for llama.cpp it implements job cancellation.
It also adds the stop icon now in place of the loading icon, that will abort the request.
Notes for Reviewers
Fixes: #974
Signed commits