Skip to content

Conversation

CosmoV
Copy link
Collaborator

@CosmoV CosmoV commented Feb 15, 2024

Closes #77

@CosmoV CosmoV self-assigned this Feb 15, 2024
@CosmoV CosmoV mentioned this pull request Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e2514e) 77.09% compared to head (f076c45) 77.28%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   77.09%   77.28%   +0.19%     
==========================================
  Files          40       40              
  Lines        2449     2457       +8     
  Branches      358      359       +1     
==========================================
+ Hits         1888     1899      +11     
+ Misses        489      487       -2     
+ Partials       72       71       -1     
Flag Coverage Δ
unittests 77.28% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...astapi_jsonapi/data_layers/filtering/sqlalchemy.py 83.63% <100.00%> (+0.45%) ⬆️
fastapi_jsonapi/schema.py 84.84% <100.00%> (+5.16%) ⬆️

@CosmoV CosmoV requested a review from mahenzon February 16, 2024 05:42
@mahenzon mahenzon merged commit cfa5248 into main Feb 16, 2024
@m-antonov m-antonov deleted the fix-joins-by-relationships branch March 13, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JOINS by relationships
2 participants