Skip to content

Fix cable plate placing on several-blocks nodes #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
S-S-X merged 6 commits into from
Apr 14, 2024
Merged

Fix cable plate placing on several-blocks nodes #358

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ab42eb
Use modulo to bring back index > 3 within {x,y,z} range
Athozus Apr 1, 2024
dbd6bb5
Fix out-of-range indexes
Athozus Apr 1, 2024
594ab5c
Add comments
Athozus Apr 5, 2024
8168f06
Use cleaner vector methods
Athozus Apr 6, 2024
d0cbd7d
Remove unnecessary normalization
Athozus Apr 6, 2024
ba01522
Add diagonal placement check
Athozus Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions technic/machines/register/cables.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,20 @@ function technic.register_cable_plate(nodename, data)
def.node_box["connect_"..notconnects[i]] = nil
if i == 1 then
def.on_place = function(itemstack, placer, pointed_thing)
local pointed_thing_diff = vector.subtract(pointed_thing.above, pointed_thing.under)
local count = 0
for axis in pairs(xyz) do
count = count + (pointed_thing.under[axis] == pointed_thing.above[axis] and 0 or 1)
if count > 1 then
return itemstack
end
end
local pointed_thing_diff = vector.direction(pointed_thing.under, pointed_thing.above)
local index = pointed_thing_diff.x + (pointed_thing_diff.y*2) + (pointed_thing_diff.z*3)
local num = index < 0 and -index + 3 or index
local crtl = placer:get_player_control()
if (crtl.aux1 or crtl.sneak) and not (crtl.aux1 and crtl.sneak) and index ~= 0 then
local fine_pointed = minetest.pointed_thing_to_face_pos(placer, pointed_thing)
fine_pointed = vector.subtract(fine_pointed, pointed_thing.above)
fine_pointed = vector.direction(pointed_thing.above,fine_pointed)
fine_pointed[xyz[index < 0 and -index or index]] = nil
local key_a, a = next(fine_pointed)
local key_b, b = next(fine_pointed, key_a)
Expand Down