Skip to content

Resolve the "Property is never assigned null so it can be removed from the property type" error detected by PHPStan #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyk merged 1 commit into from
Jan 17, 2026
Merged

Resolve the "Property is never assigned null so it can be removed from the property type" error detected by PHPStan #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Supporting/CommunicationProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
*/
public int $vNum = -1;
/**
* @var null|string
* @var string
* @ignore
*/
private string|null $host = "127.0.0.1";
private string $host = "127.0.0.1";
/**
* @var string
* @ignore
Expand All @@ -37,20 +37,20 @@
*/
private string $password;
/**
* @var string|null
* @var string
* @ignore
*/
private string|null $solution;
private string $solution;
/**
* @var null|string
* @var string
* @ignore
*/
private string|null $protocol = 'https';
private string $protocol = 'https';
/**
* @var int|null
* @var int
* @ignore
*/
private int|null $port = 443;
private int $port = 443;

/**
* @var string|null
Expand Down Expand Up @@ -533,7 +533,7 @@
* @return array|null
* @ignore
*/
private function getSupportingProviders(): null|array

Check failure on line 536 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Method INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getSupportingProviders() is unused.
{
try {
$this->callRestAPI([], true, 'GET', [], [],
Expand All @@ -553,7 +553,7 @@
* @return string|array|null
* @ignore
*/
private function getOAuthIdentifier($provider): string|array|null

Check failure on line 556 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Method INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getOAuthIdentifier() never returns string so it can be removed from the return type.

Check failure on line 556 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Method INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getOAuthIdentifier() is unused.
{
try {
$this->callRestAPI(
Expand Down Expand Up @@ -729,7 +729,7 @@
$this->returnedCount = null;
$this->errorMessage = null;

if (property_exists($this, 'responseBody')) {

Check failure on line 732 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Call to function property_exists() with $this(INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider) and 'responseBody' will always evaluate to true.
$rbody = $this->responseBody;
if (is_object($rbody)) {
if (property_exists($rbody, 'messages')) {
Expand Down
Loading