This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix connecting to database when package is registered #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstaack
approved these changes
Sep 1, 2020
Today I wanted to work on an older PR of one of my projects. My migrations worked fine a couple of months ago. When I now try to run them, they throw an error: Doctrine\DBAL\DBALException
Unknown database type geography requested, Doctrine\DBAL\Platforms\PostgreSQL100Platform may not support it.With version 5.0 it works fine. 5.1 leads to that error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove unnecessary connection to database when package is registered. I modified
createConnectionto work the same as in upstream ConnectionFactory.php and I removed registering of Doctrine custom types, because it caused similar issue to laravel/framework#28282.Is registering of Doctrine custom types really needed? For me it works without any issue.