Skip to content

Add check for snapshot, check for release instead of minecraft #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

dbergl
Copy link
Contributor

@dbergl dbergl commented Sep 23, 2013

This is a tweak to #169

Instead of checking for 'minecraft' it now checks for 'release' or 'snapshot' and grabs the latest released version as specified in the json.

@IronTetsubo
Copy link
Contributor

Hold off on this for just a sec - I was going to submit a pull request
related to this. I assume this is due to the fact that the default jargroup
isn't working right now that we added? I was going to tweak said jargroup
so the target matched "minecraft", which should address this in a simpler
fashion. Or, if not, what are you solving for here?

On Mon, Sep 23, 2013 at 12:03 PM, dbergl [email protected] wrote:

This is a tweak to #169#169

Instead of checking for 'minecraft' it now checks for 'release' or

'snapshot' and grabs the latest released version as specified in the json.

You can merge this Pull Request by running

git pull https://github.com/dbergl/minecraft-server-manager getlatest

Or view, comment on, or merge it at:

#214
Commit Summary

  • check for release or snapshot and get latest appropriate version

File Changes

Patch Links:

https://github.com/marcuswhybrow/minecraft-server-manager/pull/214.patch

https://github.com/marcuswhybrow/minecraft-server-manager/pull/214.diff

Dave Fallon

@dbergl
Copy link
Contributor Author

dbergl commented Sep 23, 2013

Current implementation doesn't allow for updating a server running the weekly snapshots without updating the URL each week. This makes it easy to update the jar for a snapshot server too.

Checking for minecraft was fine but changing the check to release or snapshot just simplified the code.

@IronTetsubo IronTetsubo mentioned this pull request Sep 24, 2013
@kbrock
Copy link

kbrock commented Mar 3, 2015

👍 This is great. Noticed it documented in article

renderorange added a commit that referenced this pull request Jul 14, 2015
Updated common.sh to create default jargroup for stable target, as mentioned in issue #215.
@renderorange
Copy link
Contributor

I still have a couple of ideas to address with this, but am working to get this one out.

@renderorange renderorange merged commit 23e3fbc into msmhq:master Jul 15, 2015
@renderorange
Copy link
Contributor

I've updated the installation and init scripts to check for this, so default installs will now pull the most recent "release" builds. This brings the installation current, so no "hacking" will need to take place to get things working. More things to catch the project up on, but this was the most pressing, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants