Skip to content

Fix error formatting #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix error formatting #463

merged 1 commit into from
Feb 26, 2021

Conversation

@hexagonrecursion
Copy link
Contributor

@hexagonrecursion hexagonrecursion commented Feb 25, 2021

While working on adding hypothesis-powered tests hexagonrecursion@f286bd2 I have noticed several places where you use the wrong formatting syntax when throwing an exception:

>>> ValueError("%s exceeds max_str_len(%s)", 10, 5)
ValueError('%s exceeds max_str_len(%s)', 10, 5)
>>> ValueError("%s exceeds max_str_len(%s)" % (10, 5))
ValueError('10 exceeds max_str_len(5)')

@methane methane merged commit 38357b9 into msgpack:main Feb 26, 2021
@methane
Copy link
Member

methane commented Feb 26, 2021

thanks

@hexagonrecursion hexagonrecursion deleted the format branch February 26, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hexagonrecursion @methane