PMREMGenerator: Use highp precision in GGX VNDF shader #32225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #32202
Description
Changes GGX VNDF shader precision from
mediumptohighpto attempt to resolve IBL darkening on Android devices (Pixel 9, Meta Quest 3).The GGX shader performs bit manipulation (Van der Corput radical inverse) and accumulates 256+ samples. On Android GPUs,
mediumpprovides only ~10 bits of mantissa precision, causing visible lighting errors.Also reduces
GGX_SAMPLESfrom 512 to 256 for better performance.