GLBufferAttribute: Add normalized property.
#31268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Update documentation and unit test. Update doc
… for the color buffer More efficient storage of colors in the GPU buffer and demonstration of the feature.
Rtwo-Dtwo
force-pushed
the
glbufferattribute-normalized
branch
from
2ea4d69 to
b4c7bdd
Compare
Mugen87
approved these changes
Jun 16, 2025
Mugen87
changed the title
normalized to GLBufferAttributenormalized property.
This was referenced Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an explicit property
normalizedto theGLBufferAttributeclass declaration. The property is already evaluated byWebGLBindingStatesand set as a parameter to the WebGL methodvertexAttribPointer. If undefined it defaults tofalse, the user could already add the property to an instance ofGLBufferAttribute. This PR makes the behavior more explicit.The documentation and tests have been extended.
The
webgl_buffergeometry_glbufferattributeexample has been modified to make usage of the property for the color buffer. Additionally, the example screenshot has been updated prior to the changes.