-
-
Notifications
You must be signed in to change notification settings - Fork 36k
WebGPURenderer: Add XRManager
.
#30346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Awesome! You already know what the changes would be, I can help if necessary. |
Not yet, tbh^^. I did a quick test with a Pixel 8a when |
On a Pixel 8a and Chrome I get the following runtime errors:
as well as
On a Quest 2, the browser console is free from errors. |
One thing I remember that hasn't been added support yet is dynamically changing the length of the |
Um, that could be the issue. The count of the array camera's sub cameras seems to vary in the Phone AR case. |
Hmm.. I'll add that support then. |
Related issue: #28968
Description
A first version of
XRManager
with basic WebXR support.Features like layers,
WEBGL_multisampled_render_to_texture
or depth sensing are missing and can be added with subsequent PRs.Tested with a Quest 2. The demo does not fully work when running the demo on Android as an AR demo, yet. I suspect We must apply some array-camera related changes to get that bit right.