Renderer: Fix `getShaderAsync()`. #29832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Nov 7, 2024

Collaborator

Mugen87 commented Nov 7, 2024

Related issue: -

Description

Fixes the currently broken getShaderAsync().


          Renderer: Fix getShaderAsync().

1a9c2ee

Mugen87 added this to the r171 milestone

github-actions bot commented Nov 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	692.22 171.45	692.22 171.45	+0 B +0 B
WebGPU	825.17 222.84	825.22 222.85	+46 B +10 B
WebGPU Nodes	824.29 222.63	824.33 222.64	+46 B +10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	464.58 112.26	464.58 112.26	+0 B +0 B
WebGPU	545.38 147.7	545.43 147.71	+46 B +10 B
WebGPU Nodes	501.32 137.43	501.37 137.44	+46 B +10 B

Mugen87 mentioned this pull request

Noise algorithm in WebGPURenderer - performance concerns #29830

Closed

Mugen87 merged commit 3728a0a into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet