Skip to content

Light: Convert to ES6 class #21231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

Light: Convert to ES6 class #21231

merged 1 commit into from
Feb 9, 2021

Conversation

@DefinitelyMaybe
Copy link
Contributor

Related issue: #19986

Description

Just the src/lights/light.js file changed to es6 class syntax

@DefinitelyMaybe
Copy link
Contributor Author

ugh. will start with the edge scripts and come back to this.

@DefinitelyMaybe DefinitelyMaybe marked this pull request as draft February 9, 2021 00:24
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 9, 2021 •
edited
Loading

It makes more sense to convert Light when all other lights are converted. Otherwise things will break.

@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021 •
edited
Loading

LightProbe: e2ddbc9
AmbientLightProbe: 0ed7a89
HemisphereLightProbe: 39104f3
DirectionalLight: ab1ed6c
PointLight: 32172e1
HemisphereLight: 7b518ca
SpotLight: c7d3c71
RectAreaLight: 6e08be5

@mrdoob mrdoob marked this pull request as ready for review February 9, 2021 15:25
@mrdoob mrdoob added this to the r126 milestone Feb 9, 2021
@mrdoob mrdoob changed the title src/lights: light.js -> es6 classes Light: Convert to ES6 class Feb 9, 2021
@mrdoob mrdoob merged commit 3d82b58 into mrdoob:dev Feb 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021

Thanks!

@mrdoob mrdoob mentioned this pull request Feb 9, 2021
Closed
@mrdoob
Copy link
Owner

mrdoob commented Feb 9, 2021 •
edited
Loading

DirectionalLightShadow: bb5cfde
PointLightShadow: b9dd2b6 aa30ab0
SpotLightShadow: 31545b9
LightShadow: 4eb500d

@DefinitelyMaybe
Copy link
Contributor Author

It makes more sense to convert Light when all other lights are converted. Otherwise things will break.

Don't mind me. that was simply the conclusion I came to upon posting the PR ... sigh

@DefinitelyMaybe DefinitelyMaybe deleted the light.js branch February 9, 2021 20:02
@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Feb 9, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r126

Development

Successfully merging this pull request may close these issues.

3 participants

@DefinitelyMaybe @Mugen87 @mrdoob