Skip to content

PropertyBinding: Convert to es6 class #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2021
Merged

PropertyBinding: Convert to es6 class #20016

merged 4 commits into from
Apr 9, 2021

Conversation

@ianpurvis
Copy link
Contributor

@ianpurvis ianpurvis commented Aug 4, 2020

Supports #19986

ianpurvis
ianpurvis commented Aug 4, 2020
View reviewed changes
@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Aug 5, 2020
Closed
43 tasks
@ianpurvis ianpurvis force-pushed the property-binding-es6-class branch from 7c389ba to 7a08899 Compare August 8, 2020 15:13
@mrdoob mrdoob added this to the r121 milestone Aug 23, 2020
@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob modified the milestones: r122, r123 Oct 28, 2020
@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 19, 2021

Is there a way to remove these Object.assign()s?

@DefinitelyMaybe
Copy link
Contributor

DefinitelyMaybe commented Feb 19, 2021 •
edited
Loading

Oh, you're not into them? I thought that given the code base had them, you would have preferred them to stay, changing incrementally as appose to full on. cool 👍

Sorry for #21294 then, that was part of what that was about.

@ianpurvis
Copy link
Contributor Author

ianpurvis commented Feb 19, 2021

Sounds good, I'll go ahead and tweak this PR to remove the Object.assign calls.

@ianpurvis
Copy link
Contributor Author

ianpurvis commented Feb 20, 2021

@mrdoob All set... 64150b7

@mrdoob mrdoob modified the milestones: r126, r127 Feb 23, 2021
Mugen87
Mugen87 reviewed Feb 25, 2021
View reviewed changes
@Mugen87 Mugen87 mentioned this pull request Mar 4, 2021
Merged
@ianpurvis ianpurvis force-pushed the property-binding-es6-class branch from 64150b7 to 86b6128 Compare March 6, 2021 14:41
@mrdoob mrdoob modified the milestones: r127, r128 Mar 30, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 9, 2021

@mrdoob Should we give this a go? It seems it's the last file in src/animations which is not yet converted.

@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2021

Lets do it 👍

@mrdoob mrdoob merged commit 2fd49ac into mrdoob:dev Apr 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2021

Thanks!

@ianpurvis ianpurvis deleted the property-binding-es6-class branch April 12, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r128

Development

Successfully merging this pull request may close these issues.

4 participants

@ianpurvis @mrdoob @DefinitelyMaybe @Mugen87