Skip to content

Conversation

@redboltz
Copy link
Contributor

@redboltz redboltz commented Oct 16, 2017

This PR fixes #699.

@codecov
Copy link

codecov bot commented Oct 16, 2017

Codecov Report

Merging #700 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage    92.7%   92.71%   +0.01%     
==========================================
  Files           8        8              
  Lines         685      686       +1     
  Branches      167      167              
==========================================
+ Hits          635      636       +1     
  Misses         50       50
Impacted Files Coverage Δ
lib/connect/tls.js 94.73% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe4d75...6384341. Read the comment docs.

@yohei1126 yohei1126 requested a review from mcollina October 16, 2017 05:21
@mcollina
Copy link
Member

can you please add a unit test for this?

'should validate successfully the CA using URI with path' fails if this
PR is not applied.
@redboltz
Copy link
Contributor Author

Hi @mcollina,
Sure. I just added unit tests for the PR.

@mcollina mcollina merged commit db7b0d4 into mqttjs:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MQTTS connection error on nodejs >= 8.6.0

2 participants