Re-enable runIdeGhcMBare and move runWithContext into the PluginAPI #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
reviewed
Nov 7, 2019
| -- --------------------------------------------------------------------- | ||
|
|
||
| runWithContext :: Monoid a => Uri -> IdeGhcM (IdeResult a) -> IdeGhcM (IdeResult a) | ||
| runWithContext uri act = case uriToFilePath uri of |
There was a problem hiding this comment.
I'm not really a fan of this function because it calls error. Is there an issue using runActionWithContext?
Why you would ever want to use this function should be documented anyway as I don't think it should ever be used in the h-i-e code base.
There was a problem hiding this comment.
This function was moved here from the test/unit/HaRePluginSpec.hs, so that it can be available for use in other modules, and is used in HaRe for running refactors.
I will see what other options we have.
There was a problem hiding this comment.
Clearly documenting it's purpose and intended usage is fine in my opinion. It mainly should be clear, that neither hie, nor hie-plugin-api is allowed to really use this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it can be used in standalone plugins, like HaRe