Skip to content

Fix #1205: add phabricator attachment links to jira #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2025
Merged

Fix #1205: add phabricator attachment links to jira #1206

merged 9 commits into from
Oct 17, 2025

Conversation

@segunfamisa
Copy link
Contributor

@segunfamisa segunfamisa commented Oct 13, 2025

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 13, 2025
@segunfamisa segunfamisa mentioned this pull request Oct 13, 2025
Closed
leplatrem
leplatrem reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good base 👌 Thank you for taking the time to contribute this!

@segunfamisa
Copy link
Contributor Author

segunfamisa commented Oct 16, 2025

Very good base 👌 Thank you for taking the time to contribute this!

Thanks for your review, @leplatrem

I have made some changes and this is ready for another review.

@segunfamisa segunfamisa marked this pull request as ready for review October 16, 2025 21:44
@segunfamisa segunfamisa requested a review from a team as a code owner October 16, 2025 21:44
@segunfamisa segunfamisa requested a review from leplatrem October 16, 2025 21:44
leplatrem
leplatrem approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I only left a few nits as comments

I may have a doubt about the name, what do you think if we name it just maybe_add_phabricator_link?
The likeliness of updating the link of an existing attachment is almost null, right?

@leplatrem leplatrem changed the title WIP: add phabricator attachment links to jira Fix #1205: add phabricator attachment links to jira Oct 17, 2025
@leplatrem leplatrem enabled auto-merge (squash) October 17, 2025 12:59
@leplatrem leplatrem merged commit 7db459a into mozilla:main Oct 17, 2025
5 checks passed
@segunfamisa segunfamisa deleted the sf/jbi-phab-attachment branch October 17, 2025 13:06
@sentry
Copy link

sentry bot commented Oct 20, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@segunfamisa @leplatrem