This repository was archived by the owner on Apr 11, 2019. It is now read-only.
[WIP] Add a directory coverage viewer. #222
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.
This is a rough prototype showing per-directory coverage data:
It hijacks
Routes
by replacingFileViewerContainer
with a newDirectoryViewerContainer
component when the requested file path ends with/
(I'd like to find a cleaner solution to identify directories from files), and it uses an ActiveData query to aggregate coverage by sub-file and sub-folder (I'd like to switch to the faster https://coverage.staging.moz.tools/v2/path endpoint).TODO:
/
)fileViewer.jsx
anddirectoryViewer.jsx
This change is