Add events workflow #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

La0 merged 23 commits into mozilla:master from La0:events

Sep 10, 2019

Collaborator

La0 commented Aug 27, 2019

Migration from release-services

⚠️ We should ship a first libmozevent version from a Mozilla repo to Pypi.

La0 requested a review from marco-c

August 27, 2019 12:51

La0 self-assigned this

La0 force-pushed the events branch 5 times, most recently from 30ce4ad to 7a45e74 Compare

August 29, 2019 09:38

La0 force-pushed the events branch 2 times, most recently from 7be15c6 to 079bd97 Compare

September 5, 2019 11:01

Bastien Abadie added 11 commits

September 9, 2019 14:37


          events: Add code review events workflow

301ffbe


          events: add unit tests

8c6a669


          events: Add CI & Dockerfile

febc03e


          events: Use updated libmozevent

6d9976c


          Add events deployment

057755e


          Use taskboot 0.1.10 to ship on heroku

6d48b65


          Assert on invalid payload

77d1d93


          Use mozilla/libmozevent

ebb394b


          Use libmozevent from Pypi

d66e4f8


          Use web worker on heroku

6d520cc


          Enable strip default hg ext in docker

9afb110

La0 force-pushed the events branch from 109d8a3 to 9afb110 Compare

September 9, 2019 12:37


          Use global mercurial conf for extensions

ea1224b

Collaborator Author

La0 commented Sep 9, 2019

This is now running OK on testing, replacing the release-services instance as https://eventlistener.testing.moz.tools/

This demo build on phab-dev was processed by this new instance

La0 mentioned this pull request

Remove pulselistener mozilla/release-services#2263

Merged

marco-c reviewed

View reviewed changes

events/docker/Dockerfile Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/docker/Dockerfile Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/docker/bootstrap.sh Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/docker/bootstrap.sh Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/setup.py Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/code_review_events/cli.py Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/code_review_events/cli.py Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/code_review_events/cli.py Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/code_review_events/cli.py Outdated Show resolved Hide resolved

marco-c reviewed

View reviewed changes

events/code_review_events/workflow.py Outdated Show resolved Hide resolved

marco-c approved these changes

View reviewed changes

Collaborator

marco-c left a comment

I'd make cli only handle cli options and move all the "architecture initialization" stuff to "workflow.py" to have everything in a single place (so it's easier to see the overall architecture by reading the code), but I don't mind the way it is now.

LGTM!

marco-c mentioned this pull request

Add events workflow mozilla/code-coverage#130

Merged

Bastien Abadie and others added 10 commits

September 9, 2019 17:07


          Update events/code_review_events/workflow.py

067e204

Co-Authored-By: Marco <[email protected]>


          Update events/code_review_events/cli.py

e701ff6

Co-Authored-By: Marco <[email protected]>


          Update events/code_review_events/cli.py

ec193ac

Co-Authored-By: Marco <[email protected]>


          Update events/code_review_events/cli.py

b4403ed

Co-Authored-By: Marco <[email protected]>


          Simplify read_requirements


          Add const for monitoring period

a585305


          Fixed VCT rev

2201b5f


          Smaller docker image

769a625


          Full cleanup in docker image

d488e0c


          Move events class in workflow

ab07f61

Collaborator Author

La0 commented Sep 9, 2019

Fixed all the comments + moved Events in workflow.py.
I just pushed on testing, will merge after some tests online


          Missing ssh

2ca5657

La0 merged commit 14e42b7 into mozilla:master

La0 deleted the events branch

September 10, 2019 12:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet