fix: don't fall back to tip when a revision cannot be found
#2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think to fix the issue you're seeing, we'd need to update https://github.com/mozilla/libmozevent instead (which is using "tip" in a few places) |
`tip` is an ambigious reference: it can be the current tip of any branch in the repository. In many cases on hg.mozilla.org, this ends up being a `tags` branch, which are forked once from an old cycle and never updated. `default` is probably what we want here, as it will always be the tip of the default branch? This came up in https://firefox-ci-tc.services.mozilla.com/tasks/D_iVb4ZSQ_mdEK-ODubB3Q: ``` 2025-06-03 13:26:43.000785 [INFO ] [info ] Mercurial stderr=b'real URL is https://hg-edge.mozilla.org/releases/mozilla-release\n' 2025-06-03 13:26:44.000194 [INFO ] [info ] Mercurial stderr=b'abort: empty revision set\n' 2025-06-03 13:26:44.000195 [INFO ] [info ] Pull updates from remote repo 2025-06-03 13:26:44.000199 [INFO ] [info ] Mercurial stdout=b'pulling from https://hg.mozilla.org/releases/mozilla-release\n' 2025-06-03 13:26:44.000661 [INFO ] [info ] Mercurial stderr=b'real URL is https://hg-edge.mozilla.org/releases/mozilla-release\n' 2025-06-03 13:26:45.000126 [INFO ] [info ] Mercurial stdout=b'searching for changes\n' 2025-06-03 13:26:45.000128 [INFO ] [info ] Mercurial stdout=b'no changes found\n' 2025-06-03 13:26:45.000486 [INFO ] [info ] Mercurial stdout=b'added 0 pushes\n' 2025-06-03 13:26:45.000598 [INFO ] [info ] Mercurial stderr=b"abort: unknown revision '9e0bb48183fc'\n" 2025-06-03 13:26:45.000599 [INFO ] [info ] Updating repo to revision tip ```
bhearsum
force-pushed
the
push-uokmxpkrqkyz
branch
from
4de86e0 to
0af65c3
Compare
|
ok, i'm fine to close this if you want |
|
I don't remember how |
|
I think you need to configure the
|
|
I think this was hit again in https://firefox-ci-tc.services.mozilla.com/tasks/IoCuKdytRne1yK28UkiT6A (Unfortunately, I don't have time to drive this home.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tipis an ambigious reference: it can be the current tip of any branch in the repository. In many cases on hg.mozilla.org, this ends up being atagsbranch, which are forked once from an old cycle and never updated.defaultis probably what we want here, as it will always be the tip of the default branch?This came up in https://firefox-ci-tc.services.mozilla.com/tasks/D_iVb4ZSQ_mdEK-ODubB3Q: