Issue #97, add explanation box - 2nd PR #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I didn't know that I could update the commits in a PR without creating a new one. Sorry about the duplicated PR. |
Contributor
|
And here is a link to the frontend from this build so you can test. |
Collaborator
|
Yes, definitely better to rewrite that:
|
Contributor
|
@InfTkm Could you update the explanation text with the one mentionned above by Marco ? |
Contributor
Author
La0
approved these changes
Mar 11, 2020
Contributor
La0
left a comment
La0
left a comment
There was a problem hiding this comment.
Thanks for this great contribution 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #97 and deleted trailing white spaces according to Taskcluster's log.
https://youtu.be/xmY6yLb7gu4
Here is a demo. Hopefully, I understood correctly where the question mark box should be.
Explanation of what I have done:
Line 59 in zero_coverage_report.js: sets the variable needs_explanation to true for the filter, completely_uncovered.
Line 138 - 146 in base.html: add the tooltip if the filter needs explanation (i.e. completely_uncovered).
At the end of style.scss: I added the CSS for the tooltip (i.e. popup explanation box) using SASS format.
Let me know if you have any questions or feedback. Thanks.