using tenacity in download_binary function

[NitishNaineni-zz]

Have used the tenacity library to implement the retry functionality into the download_binary function

Fixes #392.

[marco-c]

Why did you close the PR?

[NitishNaineni-zz]

@marco-c sorry i am figuring out how to use pull requests

[marco-c]

@marco-c sorry i am figuring out how to use pull requests

Oh, ok! No worries ;)

[marco-c]

I suggest using pre-commit to handle formatting for you

[marco-c]

You'll need to add tenacity to the requirements (https://github.com/mozilla/code-coverage/blob/master/report/requirements.txt)

[NitishNaineni-zz]

i have used per-commit and also added tenacity to requirements.txt

[NitishNaineni-zz]

@marco-c can you tell me why its failing the tests? I will try to fix it

[marco-c]

@marco-c can you tell me why its failing the tests? I will try to fix it

It seems the tests are not failing, the linting is failing (you can look at the logs on Taskcluster by clicking on "Details").

[NitishNaineni-zz]

@marco-c
i have gone through the logs this seems to be the issue

Fix requirements.txt.....................................................Failed
- hook id: requirements-txt-fixer
- exit code: 1
- files were modified by this hook

i don't understand the issue here. Can you tell me whats wrong?

[marco-c]

Probably the order of the requirements is wrong.
If you use pre-commit, all these kinds of errors will be automatically fixed for you, and you wouldn't have to care about them.

[marco-c]

@NitishNaineni you removed the branch, which closed the PR. Could you restore it?

[NitishNaineni-zz]

@marco-c
i am not able to do any git operations on it due to unstaged files. It seems i broke something so i am going to recreate and put another pull request. Sorry for the inconvenience

[marco-c]

If you create a new branch with the same name and force push it, you can update the current pull request without opening a new one.

[NitishNaineni-zz]

sorry not able to reopen it