Skip to content

--no-cache-dir option added #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 7, 2019
Merged

--no-cache-dir option added #234

merged 10 commits into from
Nov 7, 2019

Conversation

Patil2099
Copy link
Contributor

Fixes #231

@marco-c
Copy link
Collaborator

marco-c commented Oct 21, 2019

Thanks! The Docker files need to be updated too.

@Patil2099
Copy link
Contributor Author

@marco-c is this correct ?

@La0 La0 self-requested a review October 24, 2019 14:24
La0
La0 suggested changes Oct 24, 2019
View reviewed changes
@La0
Copy link
Contributor

La0 commented Oct 24, 2019

Also, please try to build the docker images on your computer (with docker build backend/Dockerfile . for example) before pushing. You would have noticed the errors that way.

@Patil2099 Patil2099 requested a review from La0 October 24, 2019 14:37
La0
La0 suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added some trailing whitespaces at the end of some Dockerfiles. The CI is not happy.

You can test locally using pre-commit

@Patil2099 Patil2099 requested a review from La0 October 30, 2019 06:22
La0
La0 suggested changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some trailing whitespaces (see CI log)

@Patil2099
Apply suggestions from code review
d0feb6f 
Co-Authored-By: Bastien Abadie <[email protected]>
La0
La0 suggested changes Oct 30, 2019
View reviewed changes
@Patil2099
Update events/Dockerfile
f404309 
Co-Authored-By: Bastien Abadie <[email protected]>
@Patil2099
Copy link
Contributor Author

@La0 I am really sorry about the inconvenience caused.

@La0 La0 self-requested a review November 7, 2019 14:11
La0
La0 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work !

@La0 La0 merged commit 3cd5258 into mozilla:master Nov 7, 2019
@Woodpile37 Woodpile37 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@La0 La0 La0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always use --no-cache-dir option for pip
3 participants
@Patil2099 @marco-c @La0