-
Notifications
You must be signed in to change notification settings - Fork 90
Split workflow in several hooks #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you split it in actual separate Taskcluster hooks? One for cron, one triggered by pulselistener. Then, you could add an argument to cli.py to choose the workflow, to make it less brittle than relying on the values of other args (https://github.com/mozilla/code-coverage/pull/165/files#diff-6310014f6dc184cfe909a867e61bfcb8R64-R77). Nit: I'd rename "mc.py" and "try_repo.py" to make it clear what they do (e.g. if we support other repos in the future, "mc.py" would not make sense anymore). "mc.py" is the task that runs at the end of a full test run, "try_repo.py" is the one that runs on-demand when developers push to try. I'm not sure what a good naming would be, maybe tests.py/all_tests.py/full_tests.py/push_tests.py/push.py/merge.py/merge_tests.py and on_demand.py? |
I went further than your comment, and used only 2 hooks:
I prefered to use 2 different endpoints, as some CLI options are not used by the cron worfklow. In the end, i think the code is a bit cleaner, as we now only have 2 different worfklows (one being parametrizable), and we can support other repos a bit more easily. |
Co-Authored-By: Marco <[email protected]>
Co-Authored-By: Marco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup!
Fixes #14
So we can work on #150