Generate a "pure" per-chunk mapping file #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll be able to use this to evaluate a first version of the coverage scheduler using per-chunk data. The per-test scheduler will be likely better, but this is a useful test (much less work to do and can already be an improvement over the status quo). |
La0
approved these changes
Aug 9, 2019
|
Activedata is a tad slow, but generation works on my computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal chunk_mapping database contains both per-test data and per-chunk data. The per-test data is only available for test suites which support per-test mode, the per-chunk data is used as a fallback for the remaining test suites.
The coverage try selector is relying on the absence of the per-chunk data for per-test-supported suites, so I can't modify the normal mapping database to add per-chunk data for per-test-supported suites.
So, I'm adding a new mapping file which contains per-chunk data exclusively.
Note: I suggest reviewing mainly the second commit, the first is just moving some code around, the third is applying formatting (as I forgot to install the git hooks before :P)