Build sqlsrv for ARM architectures too #164
Conversation
|
Note: This PR is based upon #163. |
andrewnicols
force-pushed
the
buildsqlsrv
branch
4 times, most recently
from
f44bad9 to
845589c
Compare
This change makes it much faster to make smaller changes to the image by: - moving the ADD commands to more targeted additions in order of build size - breaking out the Oracle and sqlsrv builds into their own ADD and RUN sections in the Dockerfile - moving the addition of non build-related files to right at the end of the Dockerfile These changes mean that it is possible to more easily developer the image, for example: - you can now make changes to files within the /usr directory without recompiling all PHP extensions - you can now iterate on the Oracle and/or sqlsrv extensions without recompiling all PHP extensinos - you can now iterate on the sqlsrv extension, without recompiling all PHP extensions Whist this has little effect on the end image, or the build process within CI systems, local development is substantially improved (unless you're making changes to the php-extensions.sh script).
andrewnicols
force-pushed
the
buildsqlsrv
branch
from
845589c to
e828014
Compare
|
Hi, apart from the patch (will look soon, sure it's ok), I'm a little bit confused about the versions commented above. We made SQL*Server 2017 a requirement with Moodle 3.11.0. And Moodle 3.11.x supports php73, php74 and php80. In the other side, the current msodbcsql18 driver seems to be 18.2.x and it seems to be available both to debian 11 (bullseye) and 10 (buster) (link to OS support). And, finally, the (PECL) sqlsrv extension 5.11.0 has dropped compatibility with php74. So yeah, we only can go for this to php >= 8.0 Now, looking to the patch... ciao :-) |
|
Merged into master. Will backport to >= 8.0 as commented above, paying special attention to the buster (10) builds. |
|
Ah, pity... there aren't arm64 odbc18 drivers for buster (10), only for bullseye (11):
So, in the buster versions, I'm going to disable the arm64 generation, only bullseye will have them. Ciao :-) |
|
Done, now all the images (>= php80) are using |
|
Drat, it seems that msodbcsql18 (or the new extension) comes with "Always Encrypted" enabled by default, or "Encrypt=true" on connection... so all SQL*Server jobs are now failing because of that (we don't have proper certs in the server). We need to find a way to disable the encryption by default or to make it accept self-signeds... Ciao :-) |
|
https://techcommunity.microsoft.com/t5/sql-server-blog/odbc-driver-18-0-for-sql-server-released/ba-p/3169228
Client side setting so we’ll need to put it into dboptions I guess
…On Fri, 17 Mar 2023 at 07:00, Eloy Lafuente ***@***.***> wrote:
Drat,
it seems that msodbcsql18 comes with "Always Encrypted" enabled by
default, so all SQL*Server jobs are now failing because of that (we don't
have proper certs in the server).
We need to find a way to disable the encryption by default or to make it
accept self-signeds...
Ciao :-)
—
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K74G6BT4F6OQLCO7LGDW4OLOZANCNFSM6AAAAAAV3G7NPI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
… On Fri, 17 Mar 2023 at 07:00, Eloy Lafuente ***@***.***> wrote:
Drat,
it seems that msodbcsql18 comes with "Always Encrypted" enabled by
default, so all SQL*Server jobs are now failing because of that (we don't
have proper certs in the server).
We need to find a way to disable the encryption by default or to make it
accept self-signeds...
Ciao :-)
—
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K74G6BT4F6OQLCO7LGDW4OLOZANCNFSM6AAAAAAV3G7NPI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello Everyone, HTH, |
|
Thanks @scara, yeah - that's my plan. |
|
I've created moodlehq/moodle-docker#253 @ moodle-docker. Will prepare something there soon. |
|
And have created #168 about to revert this until the 2 detected problems are fixed. |
This reverts commit 95b21cd. Part of moodlehq#168, this reverts moodlehq#164
This reverts commit 50f9dd3, reversing changes made to b532e39. Part of moodlehq#168, this reverts moodlehq#164
This reverts commit 0b6e355. Part of moodlehq#168, this reverts moodlehq#164
This reverts commit 3b36f0e. Part of moodlehq#168, this reverts moodlehq#164
|
For the records, I'm reverting the changes in the following
And I'm leaving with the ODBC 18 library and the new php-sqlsrv drivers the following images:
So we can test things with buster images while the bullseye ones (default @ CI) continue using the old / safe library and driver. Ciao :-) |
This reverts commit 50f9dd3, reversing changes made to b532e39. Part of moodlehq#168, this reverts moodlehq#164
The
msodbcsql18package is now available under the MS Bullseye repository, and they've added support for some new architectures.The new
Releasefile offers the following architecture support:I'm not sure on how the driver version may affect us, but according to the (SQL version compatibility table)[https://learn.microsoft.com/en-us/sql/connect/odbc/windows/system-requirements-installation-and-driver-files?view=sql-server-ver16]:
At the same time, Moodle 3.10 dropped support for SQL Server 2012.
Moodle 3.9 only supports PHP 7.2 - PHP 7.4.
Moodle 3.11 supports PHP 7.3 - 8.0
Moodle 4.00 supports PHP 7.3 - 8.0
Moodle 4.01 supports PHP 7.3 - 8.1
Moodle 4.02 supports PHP 8.0 - 8.2
I think we're safe to bump the msodbsql version to 18 for PHP 8.0 and up.