Skip to content

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Aug 3, 2022

@andrewnicols andrewnicols force-pushed the mdlsite-6745-handle_fatal branch from b6b6156 to 4aad9af Compare August 4, 2022 02:33
@stronk7
Copy link
Member

stronk7 commented Aug 7, 2022

I've been reading the Tracker issue and it's not clear for me if this should be considered ready or no. Please, confirm.

No matter of that, a couple of comments about the current patch could be:

  • Do we need to amend any bats test (or create a new one) to ensure the new information is correctly being output?
  • It seems that this needs a rebase on top of current master.

Ciao :-)

@andrewnicols
Copy link
Contributor Author

Do we need to amend any bats test (or create a new one) to ensure the new information is correctly being output?

I've added a new test for this.

It seems that this needs a rebase on top of current master.

Done. Only one commit missing /o\

@stronk7 stronk7 force-pushed the mdlsite-6745-handle_fatal branch from 38e36b8 to 2c235ae Compare August 9, 2022 22:49
@stronk7
Copy link
Member

stronk7 commented Aug 9, 2022

(have squashed the 2 commits, so it's all together in one now)

@stronk7 stronk7 merged commit f0652df into moodlehq:master Aug 10, 2022
@stronk7
Copy link
Member

stronk7 commented Aug 10, 2022

Here we go, used "rebase + merge" coz there was another patch landed mins ago.

Thanks all, ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants