-
Notifications
You must be signed in to change notification settings - Fork 245
DRIVERS-555 Add spec/prose tests for client-side operations timeout #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f6edba to
60d24b1
Compare
…d test runner spec
durran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TXN looks good.
iwysiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transactions look good
|
I'm going to close out this PR because it's gotten very large. I will rebase everything on the main branch, update the schema version for the unified test format spec, and make a new PR in draft mode with the final changes. |
Right now, all of the new tests are in the
client-side-operations-timeoutdirectory. When we convert the spec from Google Docs to RST, however, we'll make the required changes to the existing specs and move tests to other directories as needed.Salient points for reviewers:
generate-basic-tests.pyand all.yml.templatefiles are used for test generation. Each.yml.templatefile defines a set of tests to run and the corresponding generated.ymlfile contains each of those tests for each operation. It might be easier to review the template files and just skim over the generated ones.schemaVersionof 1.2. Note that 1.1 was skipped because it's being taken by the versioned API project, which will almost definitely close out before this one.TODO:
generate-basic-tests.pyscript needs to account for thecreateIndexesoperation. The current version only testscreateIndex.Once we know where these tests are actually ending up, we should also update the Makefile to run JSON schema checks against the test files.