Skip to content

Commit generated files automatically #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 28, 2024

Instead of asking us to regenerate files locally when forgotten, it might as well be done directly by the GitHub Action.

Example of commit: 7f27d57

@GromNaN GromNaN requested a review from a team as a code owner October 28, 2024 14:12
cd source && make -B

- name: "Commit the changes"
uses: stefanzweifel/git-auto-commit-action@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work you'll have to add a permissions key in the workflow as described in the readme:

permissions:
      contents: write

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, but that was not necessary when I tried on my own fork.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it will only make a difference if there are changes to push. Did you try a pull request that will produce a push?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that leads to this commit: 7f27d57

Let me try again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@GromNaN GromNaN requested a review from a team as a code owner October 28, 2024 15:10
@GromNaN GromNaN requested review from nbbeeken and removed request for a team October 28, 2024 15:10
@GromNaN GromNaN force-pushed the regenerate-automatically branch 3 times, most recently from d9181b2 to e1a5df6 Compare October 28, 2024 15:29
@alcaeus alcaeus removed the request for review from nbbeeken October 28, 2024 16:22
@alcaeus
Copy link
Member

alcaeus commented Oct 29, 2024

@GromNaN I believe rebasing this branch on top of master will fix the lint failure (which was fixed by #1689).

@GromNaN GromNaN force-pushed the regenerate-automatically branch from e1a5df6 to af57c04 Compare October 29, 2024 09:49
@GromNaN GromNaN merged commit c7d4d98 into mongodb:master Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants