DRIVERS-2661: Clarify requirements for CSFLE spec/prose tests #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly for consistency with spec/prose test requirements. It should have no functional impact since drivers are no longer testing on 4.1.x server versions.
jmikola
commented
Jun 23, 2023
| in a location accessible to the tests. Refer to: `Using crypt_shared`_ | ||
| - Start the mongocryptd process. | ||
| - Start a mongod process with **server version 4.1.9 or later**. | ||
| - Start a mongod process with **server version 4.2.0 or later**. |
There was a problem hiding this comment.
This won't affect drivers at all, but I saw no reason to keep references to the pre-release version at this point. This is consistent with the requirements outlined above.
| is enabled. If false, tests MUST only run if authentication is not enabled. | ||
| If this field is omitted, there is no authentication requirement. | ||
| is enabled. If false, tests MUST NOT run if authentication is enabled. If this | ||
| field is omitted, there is no authentication requirement. |
There was a problem hiding this comment.
While revising the csfle requirement I decided to switch the language to use "MUST NOT" instead of "MUST only run if CSFLE is not enabled".
I'm updating auth here for consistency, but the meaning is the same.
kevinAlbs
approved these changes
Jun 23, 2023
alcaeus
approved these changes
Jun 26, 2023
GromNaN
approved these changes
Jun 26, 2023
eramongodb
approved these changes
Jun 26, 2023
jmikola
commented
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-2661
Please complete the following before merging: