Skip to content

Conversation

@seungpark
Copy link
Collaborator

@seungpark seungpark commented Oct 3, 2025

Stories/Links:

DOP-6197
This PR fixes anchor tags sibling to composable tutorials.

Current Behavior:

Current behavior with anchor tags outside the composable tutorials: https://www.mongodb.com/docs/atlas/atlas-search/about/feature-compatibility/#supported-clients
^ The page initially loads with the proposed content, but gets pushed down by Composable Content.

Previous PR had fixed anchor tags within composable tutorials. fix still applies: http://mongodb.com/docs/atlas/atlas-search/tutorial/#create-the--index.-18

Staging Links:

Both anchor links working whether its inside/outside composables

Anchor tags within composable:
https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/tutorial/#create-the--index.-18

Anchor tags outside composable
https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/about/feature-compatibility/#supported-clients

Regression checks:

No selections: https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/tutorial
Bad selections: https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/tutorial?deployment-type=jargon
Extra query params https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/tutorial?extra-query=extra-value
Not found hash https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas/atlas-search/tutorial#extra-hash-404

Notes:

  • The fix applied here updates the behavior of the Composable tutorials as follows:
behavior Previous Current
on load - read from URL query params
- correct any wrong selections,
persist any URL parts (hash, query parms)
outside scope of composable
- if needed update, go to new URL with corrected/
updated query params
- useHashAnchor kicks in after URL update
- set composable state to show the correct content
based on URL
- read from URL query params
- correct any wrong selections,
persist any URL parts (hash, query parms)
outside scope of composable
- set composable state to show correct content
- go to new URL with params reflecting composable
state
- useHashAnchor kicks in after URL update
on select - update the url query params to reflect selections
- composable tutorials state reads from query params
- update the composable tutorial state
- update the url query params

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 148d6b2
🔍 Latest deploy log https://app.netlify.com/projects/docs-frontend-stg/deploys/68e554c2f0bb110008915a5b
😎 Deploy Preview https://deploy-preview-1568--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Oct 3, 2025

✅ Deploy Preview for csharp ready

Item Details
🔨 Latest Commit 5cb31eb091979efea29c1a1e7fff64be926b602c
😎 Deploy Preview https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/drivers/csharp
🔍 Build Logs View Logs

@docs-builder-bot
Copy link

docs-builder-bot commented Oct 3, 2025

✅ Deploy Preview for atlas ready

Item Details
🔨 Latest Commit dbc4ecf46b9d9b489ce5200840fe5475de38c475
😎 Deploy Preview https://deploy-preview-1568--docs-frontend-stg.netlify.app/docs/atlas
🔍 Build Logs View Logs

@seungpark seungpark marked this pull request as ready for review October 3, 2025 16:59
Copy link
Collaborator

@caesarbell caesarbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small nits, but other than that, LGTM.

Copy link
Collaborator

@caesarbell caesarbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small nits, but other than that, LGTM

@seungpark seungpark merged commit 937beb5 into main Oct 7, 2025
7 checks passed
@seungpark seungpark deleted the DOP-6197-outside-composables branch October 7, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants