Skip to content

DOP-6224: Remove px from Card icons #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2025
Merged

DOP-6224: Remove px from Card icons #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b0707b
remove px from card icons
mmeigs Oct 1, 2025
2660100
change to landing
mmeigs Oct 1, 2025
64540fd
update snapshots
mmeigs Oct 1, 2025
b5c6745
change netlify toml back
mmeigs Oct 6, 2025
6d77e23
Merge branch 'main' into DOP-6224-remove-px
mmeigs Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Card/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ const Card = ({ isCompact, isExtraCompact, isCenterContentStyle, isLargeIconStyl
const isLanding = template === 'landing';

let imgSize;
if (isLargeIconStyle) imgSize = '50px';
else if (isLanding) imgSize = theme.size.xlarge;
else if (template === 'product-landing') imgSize = theme.size.large;
else imgSize = theme.size.medium;
if (isLargeIconStyle) imgSize = '50';
else if (isLanding) imgSize = '64';
else if (template === 'product-landing') imgSize = '32';
else imgSize = '24';

const useCompactIcon = !['landing', 'product-landing'].includes(template);

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/__snapshots__/Card.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ exports[`renders correctly 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/university.svg"
width="24px"
width="24"
/>
<div
class="emotion-1"
Expand Down
12 changes: 6 additions & 6 deletions tests/unit/__snapshots__/CardGroup.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ exports[`renders correctly 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/atlas.svg"
width="24px"
width="24"
/>
<div
class="emotion-2"
Expand Down Expand Up @@ -281,9 +281,9 @@ exports[`renders correctly 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/university.svg"
width="24px"
width="24"
/>
<div
class="emotion-2"
Expand Down Expand Up @@ -320,9 +320,9 @@ exports[`renders correctly 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/server.svg"
width="24px"
width="24"
/>
<div
class="emotion-2"
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/__snapshots__/CardRef.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ exports[`card correctly with and without url 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/realm_sdk.svg"
width="24px"
width="24"
/>
<div
class="emotion-2"
Expand Down Expand Up @@ -435,9 +435,9 @@ exports[`card correctly with and without url 1`] = `
width: 20px;
}
"
height="24px"
height="24"
src="/images/icons/realm.svg"
width="24px"
width="24"
/>
<div
class="emotion-2"
Expand Down