Skip to content

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Sep 12, 2024

Description

What is changing?

  • Fix error inheritance
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Runtime errors indicate surprising outcomes, running out of time may be surprising but it is the intended outcome of an API that is given a deadline.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6374-error-hierarchy branch from 3a1f8c7 to 17900a6 Compare September 12, 2024 18:53
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 12, 2024
@baileympearson baileympearson self-requested a review September 12, 2024 19:18
@baileympearson baileympearson self-assigned this Sep 12, 2024
@baileympearson baileympearson merged commit 558d416 into NODE-6090 Sep 12, 2024
@baileympearson baileympearson deleted the NODE-6374-error-hierarchy branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants