-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-6367): enable mixed use of iteration APIs #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7b2a565
WIP
W-A-James bfae9d8
restore old behaviour for investigation
W-A-James 9a5539a
WIP: comment out early return
W-A-James 8af54eb
fix for mixed API use
W-A-James 472c390
change early exit condition
W-A-James 63887ba
add tests
W-A-James 5a0b45f
Merge branch 'main' into NODE-6367
W-A-James 9579af6
lint
W-A-James c676991
support mixed iteration
W-A-James bfd5385
add new tests
W-A-James 8d4ba51
remove behaviour change
W-A-James c5cae7b
remove only
W-A-James 1a3d2b1
add tests characterizing cursor iteration API mixing
W-A-James ea7b173
test fixes
W-A-James 6f33e40
lint... again
W-A-James File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.