-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-6304): Add CSOT support for non-tailable cursors #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Aug 23, 2024
W-A-James
commented
Aug 23, 2024
W-A-James
commented
Aug 23, 2024
baileympearson
requested changes
Sep 10, 2024
baileympearson
approved these changes
Sep 12, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 12, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
W-A-James
added a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 10, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Oct 14, 2024
W-A-James
added a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Operations (direct user-facing changes)
timeoutMSandtimeoutModeto all cursor-creatingCollectionandDbmethods.Cursors
AbstractCursortimeoutMSandtimeoutModeoptions to allAbstractCursorCursorInitializeOptionstype and updatedAbstractCursor._initializeto take this type as its options. Updated overrides of this type to match this signature and utilize the new options.timeoutContextproperty toAbstractCursorthat is constructed insideAbstractCursor.cursorInit()AbstractCursor.next(),AbstractCursor.tryNext()andAbstractCursor.hasNext()timeoutMSargument toAbstractCursor.closeand added CSOT timeout logic toAbstractCursor.cleanuptimeoutMSargument toAbstractCursor.cleanupmaxTimeMSfield ongetMorewhen CSOT is enabledAggregationCursor$outor$mergestages are provided to anAggregationCursorwithtimeoutMode: ITERATIONChangeStreamCursor(note, this implementation is not complete. Will be finished in NODE-6305)_initializeto make use of aformentionedCursorInitializeOptionsFindCursor_initializeto make use of aformentionedCursorInitializeOptionsListCollectionsCursor_initializeto make use of aformentionedCursorInitializeOptionsListIndexesCursor_initializeto make use of aformentionedCursorInitializeOptionsRunCommandCursor_initializeto make use of aformentionedCursorInitializeOptionsTimeoutandTimeoutContextTimeoutContext.refresh()method to reset active timeouts for cursor iteration and reuse aTimeoutContextTimeoutContext.clear()method to clear active timeouts associated with aTimeoutContextTesting
ITERATIONandCURSOR_LIFETIMEmodes work correctly for non-tailable cursorstimeoutModeandtimeoutMSoptions are passed through forrunCursorCommandAggregationCursorto ensure that$outand$mergehelpers throw if inITERATIONmodeIs there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript