test(NODE-5898): small fixes and unskips of test TODOs #4055

baileympearson · 2024-03-25T22:24:44Z

Description

What is changing?

While auditing the existing skipped tests, I found a couple of quick fixes. This PR unskips some tests that not longer fail, removes some unnecessary skip reason assignment, and removes some unnecessary TODO comments.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

Ran npm run check:lint script
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

test/integration/client-side-encryption/client_side_encryption.prose.test.js

baileympearson · 2024-03-26T17:30:28Z

test/integration/command-logging-and-monitoring/command_logging_and_monitoring.spec.test.ts

+      ({ description }) => {
+        // This is skipped because our command monitoring happens at the connection
+        // level and is using the server reply for the single insert that the bulk
+        // performed since it was only one document in the test. The test expectation
+        // is that we are using the bulk write result which was returned to the user
+        // as the reply in the command succeeded event instead of our raw reply from
+        // the server. There's nothing we can change here.
+        return description.includes(
+          'A successful unordered bulk write with an unacknowledged write concern'
+        )
+          ? `Test not applicable to Node.`
+          : false;
+      }


just added a more applicable skip reason.

I do not fully understand why this doesn't apply to us. In a world where we were writing the driver from scratch could it obey this test? if so, could this one day, allegedly, be addressed?

test/integration/crud/aggregation.test.ts

test/integration/crud/explain.test.ts

test/integration/load-balancers/load_balancers.spec.test.ts

test/integration/node-specific/client_encryption.test.ts

test/integration/node-specific/crypto_callbacks.test.ts

test/integration/unified-test-format/unified_test_format.spec.test.ts

test/tools/unified-spec-runner/runner.ts

test/unit/connection_string.test.ts

This reverts commit da3fe14.

baileympearson added 3 commits March 25, 2024 11:29

signing commit object

6ed0cc1

asdf

1534985

asdf

0e99ebd

baileympearson changed the title ~~signing commit object~~ test: small fixes and unskips Mar 25, 2024

baileympearson added 2 commits March 25, 2024 20:12

unskip test that isn't failing

f346697

fix lint

a514063