Skip to content

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Mar 19, 2024

Description

What is changing?

  • Added an eslint rule for checking mocha describe blocks for async functions
    • Run fix to remove current accidental usages
  • Use metadata to skip range tests
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

  • Async functions in context/describe blocks are incorrect usage of the test framework. We suspect this lead to a problem with mocha exiting silently on latest sharded clusters, that is no longer happening after this change.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title add temporary logging chore(NODE-6037): use metadata for skip logic and remove async from context block Mar 19, 2024
@nbbeeken nbbeeken self-assigned this Mar 19, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 19, 2024
@nbbeeken nbbeeken marked this pull request as ready for review March 19, 2024 20:13
@nbbeeken nbbeeken merged commit 8b91c30 into main Mar 19, 2024
@nbbeeken nbbeeken deleted the fix-rangepreview-tests branch March 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants