fix(NODE-4863): do not use RetryableWriteError for non-server errors #3914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-write-label-for-non-server-errors
…e-write-label-for-non-server-errors
durran
changed the title
durran
changed the title
durran
added
the
Primary Review
durran
approved these changes
Nov 8, 2023
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
Just notes for other reviewers, the testing requirements made it seem to me like the prose test #2 should change somehow, but checking the spec this test matches so no change actually needed there.
The second testing requirement I'm not sure where that came from but I think the additional unit test added here suffices.
durran
added
Team Review
nbbeeken
approved these changes
Nov 8, 2023
W-A-James
approved these changes
Nov 8, 2023
durran
deleted the
NODE-4863-no-retryable-write-label-for-non-server-errors
branch
aditi-khare-mongoDB
pushed a commit
that referenced
this pull request
Nov 17, 2023
…3914) Co-authored-by: Durran Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
MongoErrorLabel.PoolRequstedRetrylabel instead of misusedMongoErrorLabel.RetryableWriteErrorfor non-server errors according to spec.What is changing?
PoolClearedErrorconstructor adds the newMongoErrorLabel.PoolRequstedRetrylabel instead of misusedMongoErrorLabel.RetryableWriteError.isRetryableWriteErrorfunction checks if PoolRequstedRetry or RetryableWriteError is set to determine ifretryOperationis required.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4863
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript