Skip to content

Conversation

@durran
Copy link
Member

@durran durran commented Oct 31, 2023

Description

Updates the AWS ECS task definition ARN to run on Ubuntu 20.

What is changing?

  • Creates a new Evergreen environment variable for the new ARN
  • Updates AWS tests to run on Ubuntu 20 and use the new ARN.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5707

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review October 31, 2023 20:59
@alenakhineika alenakhineika self-requested a review November 1, 2023 13:33
@alenakhineika alenakhineika added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 1, 2023
@alenakhineika alenakhineika added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 1, 2023
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a question out of curiosity

@alenakhineika alenakhineika merged commit 1f63704 into main Nov 2, 2023
@alenakhineika alenakhineika deleted the NODE-5707 branch November 2, 2023 10:50
@alenakhineika alenakhineika removed the Team Review Needs review from team label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants