ci(NODE-5270): add node20 #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.evergreen/install-dependencies.sh
Outdated
| set -o errexit # Exit the script with error if any of the commands fail | ||
|
|
||
| NODE_LTS_NAME=${NODE_LTS_NAME:-erbium} | ||
| NODE_LTS_VERSION=${NODE_LTS_VERSION:-14} |
Contributor
There was a problem hiding this comment.
Should this be 12 since we're on the 4.x branch?
Contributor
Author
There was a problem hiding this comment.
Good catch, updated
baileympearson
added
the
Primary Review
baileympearson
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adds node 20 to CI
Is there new documentation needed for these changes?
Yes, next release should have the compat table updated
What is the motivation for this change?
Node 20 is soon to be LTS
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript