refactor(NODE-5170): update UnifiedMongoClient to make use of MongoDBLogWritable interface #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
NODE-4813/Implement_severity_logging_methods
to
main
April 14, 2023 19:58
W-A-James
force-pushed
the
NODE-5170/update_unified_spec_test_runner
branch
from
ddc1be8 to
39120a6
Compare
W-A-James
changed the title
baileympearson
added
the
Primary Review
| @@ -205,7 +195,7 @@ export class UnifiedMongoClient extends MongoClient { | |||
| mongodbLogPath: logCollector, | |||
| ...getEnvironmentalOptions(), | |||
| ...(description.serverApi ? { serverApi: description.serverApi } : {}) | |||
| }); | |||
| } as any); | |||
There was a problem hiding this comment.
Instead of casting this as any, can we use a ts-expect-error and in the message, link to the jira ticket?
We expect this to have a TS error until add mongodbLogPath to the client options.
baileympearson
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Updates
UnifiedMongoClientto make use of theMongoDBLogWritableinterface to collect and transform logs.Is there new documentation needed for these changes?
No
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript