test(NODE-5074): update fle2 v2 spec tests #3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
For others: Link to relevant task search for "fle2" in the logs
Changes are pretty straight forward, we may be able to make a change to the semver here permanent instead of just for temp alpha permission.
nbbeeken
added
Team Review
nbbeeken
suggested changes
Apr 6, 2023
package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@aws-sdk/credential-providers": "^3.201.0", | |||
| "mongodb-client-encryption": "^2.3.0", | |||
| "mongodb-client-encryption": "^2.8.0-alpha.0", | |||
There was a problem hiding this comment.
"mongodb-client-encryption": ">=2.3.0 <3",typo, make the change locally just to make sure package-lock gets updated
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the driver to use and test against QEv2.
What is changing?
Related: mongodb-labs/drivers-evergreen-tools#289
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5074
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript