-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-5074): update fle2 v2 spec tests #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For others: Link to relevant task search for "fle2" in the logs
Changes are pretty straight forward, we may be able to make a change to the semver here permanent instead of just for temp alpha permission.
package.json
Outdated
@@ -34,7 +34,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"@aws-sdk/credential-providers": "^3.201.0", | |||
"mongodb-client-encryption": "^2.3.0", | |||
"mongodb-client-encryption": "^2.8.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mongodb-client-encryption": ">=2.3.0 <3",
typo, make the change locally just to make sure package-lock gets updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updates the driver to use and test against QEv2.
What is changing?
Related: mongodb-labs/drivers-evergreen-tools#289
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5074
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript