Skip to content

test(NODE-5074): update fle2 v2 spec tests #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 6, 2023
Merged

test(NODE-5074): update fle2 v2 spec tests #3627

merged 16 commits into from
Apr 6, 2023

Conversation

durran
Copy link
Member

@durran durran commented Apr 6, 2023

Description

Updates the driver to use and test against QEv2.

What is changing?

  • Updates the FLE spec tests to the v2 versions.
  • Points at mongodb-client-encryption 2.8.0-alpha.0

Related: mongodb-labs/drivers-evergreen-tools#289

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5074

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review April 6, 2023 16:51
@nbbeeken nbbeeken self-assigned this Apr 6, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 6, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For others: Link to relevant task search for "fle2" in the logs

Changes are pretty straight forward, we may be able to make a change to the semver here permanent instead of just for temp alpha permission.

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 6, 2023
@durran durran requested a review from nbbeeken April 6, 2023 17:35
package.json Outdated
@@ -34,7 +34,7 @@
},
"peerDependencies": {
"@aws-sdk/credential-providers": "^3.201.0",
"mongodb-client-encryption": "^2.3.0",
"mongodb-client-encryption": "^2.8.0-alpha.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    "mongodb-client-encryption": ">=2.3.0 <3",

typo, make the change locally just to make sure package-lock gets updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated again.

@durran durran requested a review from nbbeeken April 6, 2023 17:55
nbbeeken
nbbeeken previously approved these changes Apr 6, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 8a7ce1f into main Apr 6, 2023
@nbbeeken nbbeeken deleted the NODE-5074 branch April 6, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants