-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-5069): move and improve FLE prose 14 test #3576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f2b3df to
91f1074
Compare
91f1074 to
823a726
Compare
|
Finally it reproduced. and that is with w: majority |
| @@ -0,0 +1,270 @@ | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file name "decrytion"
| expect(error).property('code', 123); | ||
| expect(aggregateFailed).nested.property('failure.code', 123); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| expect(error).property('code', 123); | |
| expect(aggregateFailed).nested.property('failure.code', 123); | |
| expect(error).to.have.property('code', 123); | |
| expect(aggregateFailed).to.have.nested.property('failure.code', 123); |
minor but we generally try for natural phrasing in our assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(there are a number of assertions like this in this file that are new)
Description
What is changing?
What is the motivation for this change?
Easier to manager modularized testing
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript