feat(NODE-3938): Add support for pre/post images in change streams #3250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
May 17, 2022
baileympearson
commented
May 17, 2022
durran
added
the
Primary Review
durran
previously approved these changes
May 18, 2022
test/integration/collection-management/collection_management.spec.test.js
Show resolved
Hide resolved
test/spec/collection-management/createCollection-pre_and_post_images.json
Show resolved
Hide resolved
durran
added
Team Review
nbbeeken
suggested changes
May 18, 2022
- spec tests synced from mongodb/specifications#1176
- changes included in this PR - mongodb/specifications#1206 - also skips the modifyCollection helper test because node doesn't implement a modify collection helper
baileympearson
force-pushed
the
NODE-3938-change-streams-pre-post-images
branch
from
0bcfca4 to
8a1aa41
Compare
nbbeeken
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>