-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: add instructions on howto test specialized environments #3009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few grammar-related notes and some clarifications. Otherwise looks great, thank you very much for putting this together!
Co-authored-by: Daria Pardue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things, otherwise I think we're good to go here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit.
Co-authored-by: Durran Jordan <[email protected]> Co-authored-by: Daria Pardue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm
Description
What is changing?
Adding some notes on how to test special environments.
What is the motivation for this change?
Adding documentation for environment variables is good to help figure out the intent. There is a risk of this document falling out of sync with reality if we don't maintain it, but having our intention documented now is helpful when someone comes back to look at how things work.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>