Skip to content

mck migration - sbom changes #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

mck migration - sbom changes #43

merged 1 commit into from
Apr 28, 2025

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Apr 25, 2025

Summary

This pull request updates the SBOM (Software Bill of Materials) generation script to reflect changes in product naming and repository structure. The most important changes involve renaming the product and repository references from "mongodb-enterprise" to "mongodb-kubernetes" and adjusting related logic and URLs accordingly.

Updates to Product and Repository Naming:

  • Updated the product name from mongodb-enterprise-cli to mongodb-kubernetes-cli in the generate_sbom_for_cli function. This change ensures consistency with the new product naming convention.
  • Changed the repository reference from mongodb/mongodb-enterprise-kubernetes to mongodb/mongodb-kubernetes in both the generate_sbom_for_cli function and the get_kondukto_sbom_data function. This aligns with the updated repository structure. [1] [2]

Adjustments to URLs and File Paths:

  • Updated the download URL for the CLI binary to reflect the new repository (mongodb-kubernetes) in the generate_sbom_for_cli function.
  • Removed redundant conditional logic in get_kondukto_sbom_data, simplifying the function by directly returning the updated repository reference.

Documentation Update:

  • Updated the file description to replace "MCO and MEKO" with "MCK," reflecting the new product focus.

Proof of Work

  • green ci
(venv) ~/projects/mongodb-kubernetes git:[sbom-changes]
make sbom-tests
===================================================================================== test session starts =====================================================================================
platform darwin -- Python 3.13.1, pytest-7.4.3, pluggy-1.5.0
rootdir: /Users/nam.nguyen/projects/mongodb-kubernetes
plugins: cov-6.0.0, socket-0.7.0, opentelemetry-1.1.0, asyncio-0.14.0, mock-3.14.0
collected 1 item                                                                                                                                                                              

generate_ssdlc_report_test.py .                                                                                                                                                         [100%]

====================================================================================== 1 passed in 5.14s ======================================================================================

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@nammn nammn requested a review from a team as a code owner April 25, 2025 12:49
@nammn nammn merged commit d767861 into master Apr 28, 2025
33 checks passed
@nammn nammn deleted the sbom-changes branch April 28, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants